Show whole topic Sep 02, 2008 10:21 am
Eiko Offline
Moderator, Developer
Registered since: Aug 03, 2007
Location: -


Subject: Re: Patches
Thanks for the patches.

I checked in the update for the lang file.

why did interplay rename all the wav files?!? They did it with the music files, too. There they used .msc. anyway...

A few remarks about the resinstaller patch:
- Duplicating all the wav related functions is not the best way to go. Generally duplicating code should be avoided. you could use a string to store the wave file extension. Set the string to .wav or .spw, depending on the tests, and use this string to generate all the sound file names.
- You can use the function openFile (from file.cpp) so you don't have to distinguish between upper and lower case file names.
- You don't need to test with extra path delimiter as it is added to sMAXPath earlier if missing.
This post has been edited 2 times. Last edit on Sep 02, 2008 12:10 pm by Eiko.