Subject: Re: Patches
Quote by Eiko:
- Duplicating all the wav related functions is not the best way to go. Generally duplicating code should be avoided. you could use a string to store the wave file extension. Set the string to .wav or .spw, depending on the tests, and use this string to generate all the sound file names.
I thought of that too. It was easier at the time to just do a search and replace on ".WAV" to ".SPW".
Quote:
- You can use the function openFile (from file.cpp) so you don't have to distinguish between upper and lower case file names.
- You don't need to test with extra path delimiter as it is added to sMAXPath earlier if missing.
I just followed the example of the language test, where both of those were done... sorry!
What is to be done now?
This post has been edited
1
times. Last edit on Sep 02, 2008 2:55 pm by shaktazuki.