Subject: Re: Singlepayer scenario

---

hi ness,

I found a little time to look at the scenarios (or at least at the patch file you posted).

I did not test it in real yet because it does not match the current source code anymore. Would it may be possible to upload a new package?

Some comments on the code so far:

At first: I like it. Looks realy good in general!

One thing I would like to mention is that you did not stick to our coding guidelines. That's not dramatic for now, but before any code goes into GIT it should match the rest of the code (at least in most points).

An other thing is about the usage of the "cGame" class. The current class hierarchy was not intended to be extended for such scenarios. Actually it was not intended to stay there at all. It should serve as temporary place where I could collect the information about different game starts (single player, multiplayer host/client, hot seat). Sp now it is easy to check which information those game starts have in common and which ones they don't so the whole thing can be replaced with something different, more generic that does not introduce any code duplication. But for now, it is okay, how you did it because this new and shinny solution is not available yet. I just wanted you to know about the issues so that you may do not loose any time and effort into something that has to be redone later on anyway.

edit:
here are two links about our coding guidelines:
- an old one in german: https://www.maxr.org/showtopic.php?id=163&page=2
- and a newer one in english: https://www.maxr.org/showtopic.php?id=652

---