argv0 Jun 04, 2010 1:58 pm
Subject: load game problem

Firstly, great job! Its amazing to see a small team reproduce such a great game in such perfect detail. Like everyone else here, I love this game and always wanted more of it.

So, to the point. I've been playing with it a bit, and diving into the source code when possible, and I'm having a problem when I try to load one of my save games. I've just been playing the single player so far, but when I try to load a previous save (from the main menu), the whole game freezes. I'm not sure if anyone else has seen this before, but I have some details:

When I drop some traces in the code, it gets all the way to serverevents.cpp line 1110

void sendSavedReport ( sSavedReportMessage &savedReport, int player )
{
    cNetMessage* message = new cNetMessage( GAME_EV_SAVED_REPORT );
    ...
    Server->sendNetMessage( message, player ); // <- LINE 1110
}

And when it tries to send the netmessage it seems to hang, possibly waiting for a response. A little more tracing showed me the message was probably not even arriving at all (which is weird).

Now, for the catch...
I dropped some breakpoints in visual studio and ran it again, stepping through this area slowly. And... success, it loaded correctly. Removing the breakpoints and trying it normally afterward caused it to fail again.

Any help would be appreciated, and I can also try to dig up some more information.

Thanks,
Jason

alzi Jun 04, 2010 3:46 pm
Subject: Re: load game problem

hi argv0 and welcome to our community,

first it would be nice if you could upload the savegame. Then it is important to know with which version of the game the savegame was saved and which version you are using now.
I think waiting for a response can not be the reason becouse in general we never wait directly for responses. Loosing net messages would very unusal as well... weird attitude ^^
The information mentioned above may could help me a little.

PS: Actually such problems should be posted on the bugtracker and not in the forum.

argv0 Jun 05, 2010 4:16 pm
Subject: Re: load game problem

I uploaded my save game (slot 001). I also tried moving it into other slots (3, 4, 10) but it still didn't work correctly (it loaded once correctly out of about 6 attempts - probably a fluke).
And I am using svn revision 2689. I downloaded maxr-0.2.6.exe, then patched it with May 31 svn latest. And I've been building with visual studio 2010. I'm still using the same version, with only a few minor UI adjustments.

I hope this helps, and if there's anything else or anything I missed, let me know. I'll continue digging around here.
Attachments:
Save001.zip (Filesize: 21.14 KB)

alzi Jun 07, 2010 2:05 pm
Subject: Re: load game problem

Hm, I can't reproduce this error here. The save has been loaded correctly every time on my computer. I have looked into the save file and it seams to be correct (as far as i can say this about such a big file)
I realy don't know where the problem could be, sry oO

Eiko Jun 07, 2010 2:25 pm
Subject: Re: load game problem

Could you upload a net.log from an attempt to load the game? I had recently an other report about freezing when loading a game.

I couldn't reproduce it either, but it would be interesting to see, whether it freezes at the same position, in your case.

argv0 Jun 07, 2010 7:26 pm
Subject: Re: load game problem

Here's a net.log that shows some of whats happening. I launched the game 31 times and checked the net.log each time. In two cases it worked fine and this log file is a pretty good representation of what's happening most of the time.

At the bottom of the log file, there is a block of GAME_EV_SAVED_REPORT messages which (about half the time) is replaced with a large block of unit loading messages. There's no other notable differences between the various log files.

I'm gonna try rebuilding a core maxr install and diffing it with my current, I must have made a mistake somewhere.
Attachments:
net-07.06.10-1421.zip (Filesize: 18.59 KB)

Eiko Jun 07, 2010 8:18 pm
Subject: Re: load game problem

What's happening there? Surprised There is not a single client message in the log Embarrassing

It seems, that the client thread freezes. So the server ends waiting in the send message function, because the event queue runs full. Thats very strange.

Is this always the case? Can you switch to the client thread (the main thread), when the game freezes and have a look which function is called there?

Thanks for your help to track down this problem! Smiling

beko Jun 08, 2010 8:03 am
Subject: Re: load game problem

me smells firewall.

argv0 Jun 09, 2010 8:09 pm
Subject: Re: load game problem

Firewall, would have been an awesome answer, but disabling it didn't help. You had my hopes up there, and I'll keep it in mind with future tests.

There's no pause button on my visual studio, so I can't tell where the main thread is when it hangs, so I'm still trying to figure that out. I did find something about the client messages though. According to the couple of net logs I have where it *did* work, the next message that the client should receive is "GAME_EV_HUD_SETTINGS" and it looks like it should happen at the same time the game hangs.

I then proceeded to check for the error in the out-of-box version and I still go it (with none of my modifications).

But it seems like this might be an isolated incident that's barely affecting anyone if that, I'll continue my search and report back, but you guys don't have to waste your time on this.

-Jason

*EDIT* since the game is multithreaded, is there any reason to believe my puny little single core computer could be causing part of it?

beko Jun 09, 2010 9:14 pm
Subject: Re: load game problem

nono, not your cpu Smiling multithreading didn't come with multicores.

Eiko is working on this and afair he has an idea why that happens to you.