ness Jul 20, 2014 11:09 pm
Subject: For DEV again: Crash when killing my own scanner

Hi again,

First crash, simply started single map loaded a few assault guns and (bad idea) just tried to kill my scanner... BOOM

client.cpp: 1826

It seems following code crashes only when you kill your own scanner:
DownloadSource code (C++):
  1. void cClient::deleteUnit (cVehicle* vehicle)
  2. {
  3.         ...
  4.  
  5.         owner->removeUnit (*vehicle);
  6.  
  7.         owner->doScan();
  8. }

beko Jul 20, 2014 11:39 pm
Subject: Re: For DEV again: Crash when killing my own scanner

What git version did you use?

beko Jul 21, 2014 3:22 pm
Subject: Re: For DEV again: Crash when killing my own scanner

I opened registration: https://git.maxr.org/users/sign_up

You may now create a git account and post bugs there ness. That'd help to keep stuff organized Smiling

ness Jul 21, 2014 8:54 pm
Subject: Re: For DEV again: Crash when killing my own scanner

Extra,

Issue created:
https://git.maxr.org/maxr/maxr/issues/867

alzi Jul 21, 2014 9:44 pm
Subject: Re: For DEV again: Crash when killing my own scanner

Thanks for the ticket! I left a comment on it on gitlab.

I added a new label "menu_event_refactoring" to the ticket, so that is easier to find tickets that are for the branch and not master.

An other thing I want to make clear is that the branch is in kind of an unstable state at the moment.

There are many known issues that I have on a hand written list here. I did not add them to the tracker yet, because I thought no one besides me was working with the branch yet.

Nevertheless I'm very glad that someone else is testing the branch as well. I'm pretty sure that I have introduced many new bugs to the code while refactoring and it will be hard to find them all by myself Innocent

ness Jul 22, 2014 9:59 am
Subject: Re: For DEV again: Crash when killing my own scanner

Hello,

At the moment I'm just reading some code to try to understand how maxr works,
I picked up that branch because it seems to be the more active, and because we talked about in the forum so i wanted to see how it looks like.
So yes, I will probably make some simple tests from time to time, I'll push tickets if i find something else Smiling

See you

alzi Jul 22, 2014 11:28 am
Subject: Re: For DEV again: Crash when killing my own scanner

That's nice to hear.

If there are any questions regarding the code, feel free to ask Smiling