Mechanized Assault & eXploration Reloaded

Hello Guest! (New posts) Forum

Search
Important Tools
Misc. links
- Mark forums read
- Guidelines
Active topics...
- in the last 24 hours
- since my last visit
Newsfeeds (RSS, ...)
- RSS 2.0
- RSS 1.0
- OPML
- Klipfolio
- Atom 1.0
Log in

Topic Options

Pages (1): 1

Show first unread post

Apr 10, 2010 8:40 pm

jezz

Approved Member

Registered since: Apr 10, 2010
Posts: 1

Subject: Some problems reported by valgrind

Hi,
I like original M.A.X. and I want to help with Reloaded version. I have used valgrind to check memory related problem in svn revision 2674. It reports, that mismatched free()/delete/delete[] was used. Also base class cMenu has virtual methods but it does not have virtual destructor. I have created patch for this two problems.

DownloadSource code (C++):

Index: movejobs.cpp
===================================================================
--- movejobs.cpp (revision 2674)
+++ movejobs.cpp (working copy)
@@ -120,7 +120,7 @@
{
for ( int i = 0; i < blocknum; i++ )
{
- delete MemBlocks[i];
+ delete [] MemBlocks[i];
}
free ( MemBlocks );
}
Index: menus.h
===================================================================
--- menus.h (revision 2674)
+++ menus.h (working copy)
@@ -282,6 +282,10 @@
virtual void recalcPosition( bool resetItemPositions );
public:
+ /**
+ * virtual destructor
+ */
+ virtual ~cMenu() {}
/**
* redraws the menu background, the cursor and all menuitems.
*@author alzi

Just wondering - why there is not used STL (e.g. std::vector instead of clist)? And std::swap can be used to swap two values without defining temporary variable (movejobs.cpp).

Thank you for your great work. This game rocks Cool

Apr 11, 2010 7:28 pm

beko

Developer, Administrator

Registered since: Jun 04, 2004
Posts: 2,279

Subject: Re: Some problems reported by valgrind

hi jezz and thanks for your feedback. We appreciate patches a lot but the best place would be to open a ticket on our bugtracker (possible with your forum account) so we won't forget to apply the patch as well Wink