Mechanized Assault & eXploration Reloaded



#1 Jul 20, 2014 11:09 pm
ness Offline
Developer
Registered since: Nov 12, 2010
Posts: 59


Subject: For DEV again: Crash when killing my own scanner
Hi again,

First crash, simply started single map loaded a few assault guns and (bad idea) just tried to kill my scanner... BOOM

client.cpp: 1826

It seems following code crashes only when you kill your own scanner:
DownloadSource code (C++):
  1. void cClient::deleteUnit (cVehicle* vehicle)
  2. {
  3.         ...
  4.  
  5.         owner->removeUnit (*vehicle);
  6.  
  7.         owner->doScan();
  8. }
This post has been edited 1 times. Last edit on Jul 20, 2014 11:10 pm by ness. ↑  ↓

#2 Jul 20, 2014 11:39 pm
beko beko Offline
Developer, Administrator
Registered since: Jun 04, 2004
Posts: 2,279


Subject: Re: For DEV again: Crash when killing my own scanner
What git version did you use?
Bernd Kosmahl
"Sir, we are surrounded!" - "Great - we can attack in any direction."
↑  ↓

#3 Jul 21, 2014 3:22 pm
beko beko Offline
Developer, Administrator
Registered since: Jun 04, 2004
Posts: 2,279


Subject: Re: For DEV again: Crash when killing my own scanner
I opened registration: https://git.maxr.org/users/sign_up

You may now create a git account and post bugs there ness. That'd help to keep stuff organized Smiling
Bernd Kosmahl
"Sir, we are surrounded!" - "Great - we can attack in any direction."
↑  ↓

#4 Jul 21, 2014 8:54 pm
ness Offline
Developer
Registered since: Nov 12, 2010
Posts: 59



#5 Jul 21, 2014 9:44 pm
alzi alzi Offline
Developer, Moderator
Registered since: Aug 12, 2007
Posts: 339


Subject: Re: For DEV again: Crash when killing my own scanner
Thanks for the ticket! I left a comment on it on gitlab.

I added a new label "menu_event_refactoring" to the ticket, so that is easier to find tickets that are for the branch and not master.

An other thing I want to make clear is that the branch is in kind of an unstable state at the moment.

There are many known issues that I have on a hand written list here. I did not add them to the tracker yet, because I thought no one besides me was working with the branch yet.

Nevertheless I'm very glad that someone else is testing the branch as well. I'm pretty sure that I have introduced many new bugs to the code while refactoring and it will be hard to find them all by myself Innocent
Albert Ziegenhagel
↑  ↓

#6 Jul 22, 2014 9:59 am
ness Offline
Developer
Registered since: Nov 12, 2010
Posts: 59


Subject: Re: For DEV again: Crash when killing my own scanner
Hello,

At the moment I'm just reading some code to try to understand how maxr works,
I picked up that branch because it seems to be the more active, and because we talked about in the forum so i wanted to see how it looks like.
So yes, I will probably make some simple tests from time to time, I'll push tickets if i find something else Smiling

See you
↑  ↓

#7 Jul 22, 2014 11:28 am
alzi alzi Offline
Developer, Moderator
Registered since: Aug 12, 2007
Posts: 339


Subject: Re: For DEV again: Crash when killing my own scanner
That's nice to hear.

If there are any questions regarding the code, feel free to ask Smiling
Albert Ziegenhagel
↑  ↓

Pages (1): 1


All times are GMT +02:00. Current time: 12:02 am.