Mechanized Assault & eXploration Reloaded



#11 Sep 10, 2014 10:46 pm
ness Offline
Developer
Registered since: Nov 12, 2010
Posts: 59


Subject: Re: Singlepayer scenario
Hi,

Glad you had the time look at it, and that you like it Smiling

I will upload a new package in few days, now AI can put units on 'patrol', follow a path on the map.
I'd like to have at least one 'playable' scenario (not just for tests) to demonstrate what the system can do up to now.

For the code:

* code guidelines: yes i wrote quickly at first time, now I'll try to find some time to reach the guidelines... but is it necessary to read and learn all those 94 rules ? Sad

* cGame and other maxr class usage. I did my best to understand how it works and interface the scenario, trying to 'copy-paste' from singleplayer game and some other classes. Of course this is not optimal and refactoring will be necessary; this is not a problem at all.

Question: for git submission, do you have also guidelines for git commits, do I need to rebase all commit in one big commit or could it be that the day to day commit stays in the scenario branch ?

++
↑  ↓

#12 Sep 10, 2014 11:24 pm
alzi alzi Offline
Developer, Moderator
Registered since: Aug 12, 2007
Posts: 339


Subject: Re: Singlepayer scenario
I think it is not 100% important to read and learn all the rules. You can orient yourself on the code that is already written, but be aware that it is not fully consistant yet.

The most important would be the naming guidelines for class, method and variable names. After that the reformating could be done by a tool. There should be an AStyle format file in the repository that you could use.

About GIT guidelines: There are none I would know of. The master should always compile, run and be kind of stable. Anything else is up to you.
Albert Ziegenhagel
This post has been edited 1 times. Last edit on Sep 10, 2014 11:28 pm by alzi. ↑  ↓

#13 Sep 12, 2014 9:23 am
ness Offline
Developer
Registered since: Nov 12, 2010
Posts: 59


Subject: Re: Singlepayer scenario
Ok I will do my best, but I have completely different coding guidelines on other projetcs so it might be that sometimes I will miss it Smiling
↑  ↓

Pages (2): 1, 2


All times are GMT +02:00. Current time: 12:53 pm.